Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22182: Page history is missing after a page containing attachments is moved #3133

Closed
wants to merge 1 commit into from

Conversation

surli
Copy link
Member

@surli surli commented May 23, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-22182

Changes

Description

  • apply the criteria over the archive in cache when possible instead of always loading it from database

Clarifications

Screenshots & Video

Executed Tests

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 15.10.x
    • 16.4.x

…nts is moved

  * apply the criteria over the archive in cache when possible instead
    of always loading it from database
@surli surli added backport stable-15.10.x Used for automatic backport to 15.10.x branch. backport stable-16.4.x labels May 23, 2024
@surli
Copy link
Member Author

surli commented May 24, 2024

We won't keep that solution which is not working: first, there's a problem when saving the doc so we get a rollback and we can never save a rename with attachment, second, the archive is actually not set to the doc so the changes here are pretty much useless. Instead we're going to just revert changes from #2926 to fix the bug.

@surli surli closed this May 24, 2024
@surli surli deleted the XWIKI-22182 branch May 24, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable-15.10.x Used for automatic backport to 15.10.x branch. backport stable-16.4.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant