XWIKI-22209: Deprecate NotificationFilterPreference#isActive #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmortagne
reviewed
Jun 4, 2024
...n/java/org/xwiki/notifications/filters/internal/scope/ScopeNotificationFilterPreference.java
Outdated
Show resolved
Hide resolved
tmortagne
approved these changes
Jun 4, 2024
manuelleduc
reviewed
Jun 4, 2024
| */ | ||
| @Deprecated(since = "16.5.0RC1") | ||
| boolean isActive(); |
There was a problem hiding this comment.
Do you plan to move this to legacy?
There was a problem hiding this comment.
Yes I started to work on providing legacy interface as part of #2882 the plan would be to move that method to legacy too once the other PR is merged.
There was a problem hiding this comment.
Actually I can't move it yet to legacy: the column isActive is exposed in hibernate configuration so hibernate needs a getter for it and moving to legacy means that it would be lost in standard docker tests leading to errors.
I will add a note in javadoc.
Now note that my goal is to refactor the hibernate mapping for filters as part of #3154 so I should be able to do it in there.
* Ensure to not use anymore isActive and setActive
* Provide a default method for the deprecated method in interface and
remove all overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22209
Changes
Description
Clarifications
N/A
Screenshots & Video
N/A
Executed Tests
mvn clean install -Pquality,integration-tests,dockeron modulexwiki-platform-notificationsand onxwiki-platform-legacy-notificationsExpected merging strategy