Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eden attribute for PowerOn on mission start #341

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

GermanHydrogen
Copy link
Collaborator

Added an eden attribute to power devices to power them on, on mission start.

@GermanHydrogen GermanHydrogen added the enhancement New feature or request label Mar 14, 2023
@GermanHydrogen GermanHydrogen self-assigned this Mar 14, 2023
@y0014984
Copy link
Owner

Perhaps we should add some logic that guarantees that all power producing devices are turned on before power consuming devices are turned on.

Also we should check that the devices are turned on after all Eden Editor power connections are established.

At this point an init diagram could be useful, to keep track of what happens when on startup (Init Devices, Add Connections, Turn on Generators, Turn on Consumers)

My simple setup was a generator, a quad lamp and a power connection defined in Eden Editor. The sound played, but the generator was off. If the connection was not present on start, the generator was on. The lamp was always off.

@y0014984
Copy link
Owner

The previously described bug appeared in singleplayer. In hosted multiplayer it worked and also the lamp was on.

Despite that we should be able to guarantee the order of execution.

@y0014984
Copy link
Owner

If the lamp is created in Editor before the generator, the lamp will be turned on before the generator is turned on. At this moment there is no power source and the lamp stays off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants