Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organized the library module for future changes #280

Closed
wants to merge 1 commit into from

Conversation

BobbyESP
Copy link
Contributor

Part of #256

@JunkFood02
Copy link
Collaborator

Changing package name would bring a lot of build failure and needs manual migration for end users (like the changeset in the app module). Unless we have a better reason, I'd like to keep the API change minimal. Ideally, the refactor should be made under the hood without introducing a big breaking change.

@BobbyESP
Copy link
Contributor Author

BobbyESP commented Jul 5, 2024

Changing package name would bring a lot of build failure and needs manual migration for end users (like the changeset in the app module). Unless we have a better reason, I'd like to keep the API change minimal. Ideally, the refactor should be made under the hood without introducing a big breaking change.

Makes sense. I'll be using the new folders/packages for only the new changes and keep the current structure.

Thanks for the review!

@BobbyESP BobbyESP closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants