-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(gen) add grunt-ngdoc to Gruntfile #680
base: master
Are you sure you want to change the base?
Conversation
How much test coverage should be have here? |
@@ -38,10 +38,17 @@ module.exports = function (grunt) { | |||
coffeeTest: { | |||
files: ['test/spec/{,*/}*.{coffee,litcoffee,coffee.md}'], | |||
tasks: ['newer:coffee:test', 'karma'] | |||
}, | |||
js: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably get named jsdocs
these two lines should be modified: https://github.com/marcin-wosinek/generator-angular/blob/ngdocs-grunt/templates/common/root/_Gruntfile.js#L77-L78 |
In the lines you've mentioned I've added watching for changes in documentation. |
I meant this line will livereload and put files in .tmp: https://github.com/yeoman/generator-angular/pull/680/files#diff-c90fa6beac4c4a4ca179fcb210e6e096R43 |
No, not for the docs. Im talking about normal JS. When a .coffee file is edited, it does not trigger a live reload. CS writing the processed files to the .tmp folder trigger the live reload. With your change, a live reload is also triggered when the docs are updated. Line 78 of your changes should be removed since line 46 will do the same. |
updated |
},<% } else { %> | ||
js: { | ||
files: ['<%%= yeoman.app %>/scripts/{,*/}*.js'], | ||
tasks: ['newer:jshint:all'], | ||
tasks: ['ngdocs', 'newer:jshint:all'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these tasks be reversed or does it matter?
Ideally these should be available on a different "site". As in not part of the actual site the user is building since end users of the developers project don't/shouldn't need to see the docs for the code part. |
Grunt part of the pull request #551