Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

feat(gen) add grunt-ngdoc comments #681

Merged
merged 1 commit into from
May 13, 2014

Conversation

marcin-wosinek
Copy link
Contributor

Comments part of the pull request #551

@@ -1,5 +1,14 @@
'use strict'

=======
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the double bars on this one necessary?

@eddiemonge
Copy link
Member

Commit message is missing colon

@marcin-wosinek
Copy link
Contributor Author

Review applied & commit rebased.

@eddiemonge
Copy link
Member

I already know this is going to cause a few issues but oh well, I like overly verbose documentation. I'd rather have too much than none. I'd prefer to have just the right amount though.

@@ -1,5 +1,13 @@
'use strict'

###*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless there is a specific reason for the trailing * I think it should be removed and the next *s replaced with # in this and the other CS files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing * is necessary.
### becomes /*
###* becomes /**
and
`####' becomes error

and ngdocs loads only comments starting with /**

@marcin-wosinek
Copy link
Contributor Author

rebased and changed - single * are replaced by #.

Btw. Travis is impressive fast recently.

eddiemonge added a commit that referenced this pull request May 13, 2014
@eddiemonge eddiemonge merged commit ec521e2 into yeoman:master May 13, 2014
@marcin-wosinek marcin-wosinek deleted the ngdocs-comments branch May 13, 2014 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants