-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Conversation
@@ -1,5 +1,14 @@ | |||
'use strict' | |||
|
|||
======= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the double bars on this one necessary?
Commit message is missing colon |
Review applied & commit rebased. |
I already know this is going to cause a few issues but oh well, I like overly verbose documentation. I'd rather have too much than none. I'd prefer to have just the right amount though. |
@@ -1,5 +1,13 @@ | |||
'use strict' | |||
|
|||
###* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless there is a specific reason for the trailing *
I think it should be removed and the next *
s replaced with #
in this and the other CS files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing * is necessary.
###
becomes /*
###*
becomes /**
and
`####' becomes error
and ngdocs loads only comments starting with /**
rebased and changed - single Btw. Travis is impressive fast recently. |
feat(gen) add grunt-ngdoc comments
Comments part of the pull request #551