Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Creating Generator instructions #829

Merged
merged 5 commits into from
Jan 25, 2025
Merged

Conversation

Jason3S
Copy link

@Jason3S Jason3S commented Oct 13, 2023

With the release of yeoman-generator v6, generators need to be ESM Modules.

With the release of `yeoman-generator` `v6`, generators need to be ESM Modules.
@mischah
Copy link
Member

mischah commented Oct 13, 2023

Deploy Preview for yeoman ready!

Name Link
🔨 Latest commit 7d0c3b4
🔍 Latest deploy log https://app.netlify.com/sites/yeoman/deploys/6529620be5a1e60008b5d930
😎 Deploy Preview https://deploy-preview-829--yeoman.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

app/authoring/index.md Outdated Show resolved Hide resolved
app/authoring/composability.md Outdated Show resolved Hide resolved
app/authoring/composability.md Outdated Show resolved Hide resolved
app/authoring/composability.md Outdated Show resolved Hide resolved
app/authoring/composability.md Outdated Show resolved Hide resolved
app/authoring/composability.md Outdated Show resolved Hide resolved
app/authoring/composability.md Outdated Show resolved Hide resolved
app/authoring/index.md Outdated Show resolved Hide resolved
app/authoring/index.md Outdated Show resolved Hide resolved
Copy link

netlify bot commented Jan 25, 2025

Deploy Preview for yeoman ready!

Name Link
🔨 Latest commit 446f21d
🔍 Latest deploy log https://app.netlify.com/sites/yeoman/deploys/6794416831fa580008039717
😎 Deploy Preview https://deploy-preview-829--yeoman.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mshima mshima changed the base branch from main to esm January 25, 2025 01:43
@mshima
Copy link
Member

mshima commented Jan 25, 2025

Thanks @Jason3S I will merge to a branch so we can continue from there.

@mshima mshima merged commit 7ae42b7 into yeoman:esm Jan 25, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants