Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored the TODO example for readability and performance. Specifically:
toggle_all
toset_completed
to be clearer on intentiontoggle
totoggle_completed
to be inline withset_completed
new
function for state (I'm not sure why I did this, can revert 🙂)Vec::retain
to remove completed entriesAs a newcomer I found it a bit hard to follow all of the iterator work being done in the
state.rs
file. It seemed that most were because the indexes were calculated after filtration in the view side, and hopefully this PR makes it easier for others.Checklist