Sweep: Sweep: Modify, refactor and integrate the code

BIMAPI_HW2/BIMAPI_HW2.csproj

@@ -7,7 +7,7 @@
     <ProjectGuid>{1251CFD1-EB24-46F1-9C1A-07773BF85625}</ProjectGuid>
     <OutputType>Library</OutputType>
     <AppDesignerFolder>Properties</AppDesignerFolder>
-    <RootNamespace>BIMAPI_HW2</RootNamespace>
+    <RootNamespace>BimApiRevitFamilyParametersGenerator</RootNamespace>
     <AssemblyName>BIMAPI_HW2</AssemblyName>
     <TargetFrameworkVersion>v4.7.2</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
@@ -17,14 +17,16 @@
     <DebugSymbols>true</DebugSymbols>
     <DebugType>full</DebugType>
     <Optimize>false</Optimize>
-    <OutputPath>bin\Debug\</OutputPath>
-    <DefineConstants>DEBUG;TRACE</DefineConstants>
+    <OutputPath>bin\Release\</OutputPath>
+    <DefineConstants>TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
+    <Compile Include="Utils.cs" />
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>
     <Optimize>true</Optimize>
+    <Compile Include="Utils.cs" />
     <OutputPath>bin\Release\</OutputPath>
     <DefineConstants>TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
@@ -38,6 +40,12 @@
       <HintPath>..\..\..\..\..\..\Program Files\Autodesk\Revit 2019\RevitAPIUI.dll</HintPath>
     </Reference>
     <Reference Include="System" />
+    <Reference Include="System.Xml.Linq" />
+    <Reference Include="System.Data.DataSetExtensions" />
+    <Reference Include="Utils.cs" />
+    <Reference Include="System.Xml.Linq" />
+    <Reference Include="System.Data.DataSetExtensions" />
+    <Reference Include="Utils.cs" />
     <Reference Include="System.Core" />
     <Reference Include="System.Drawing" />
     <Reference Include="System.Windows.Forms" />
@@ -49,6 +57,7 @@
     <Reference Include="System.Xml" />
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="Utils.cs" />
     <Compile Include="GenerateFamilyParameter.cs" />
     <Compile Include="Form1.cs">
       <SubType>Form</SubType>
@@ -60,6 +69,7 @@
       <AutoGen>True</AutoGen>
       <DesignTime>True</DesignTime>
       <DependentUpon>Resources.resx</DependentUpon>
+      <DependentUpon>Utils.cs</DependentUpon>
     </Compile>
     <Compile Include="Properties\AssemblyInfo.cs" />
   </ItemGroup>

BIMAPI_HW2/Form1.cs

@@ -6,13 +6,13 @@
 using System.Linq;
 using System.Text;
 using System.Threading.Tasks;
-using System.Windows.Forms;
+using System.Windows.Forms.IWin32Window;
 using Autodesk.Revit.UI.Selection;
 using Autodesk.Revit.DB;
 
-namespace BIMAPI_HW2
+namespace BimApiRevitFamilyParametersGenerator
 {
-	public partial class Form1 : System.Windows.Forms.Form
+	public partial class FamilyParameterGeneratorForm : System.Windows.Forms.Form
 	{
 		public Document doc;
 		public Selection selElement;

BIMAPI_HW2/GenerateFamilyParameter.cs

@@ -10,15 +10,15 @@
 using System.Windows.Forms;
 using System.Threading.Tasks;
 using System.Collections.Generic;
-using BIMAPI_HW2;
+using Autodesk.Revit.DB; using Autodesk.Revit.UI; using Autodesk.Revit.Attributes; using Autodesk.Revit.DB.Structure; using Autodesk.Revit.UI.Selection; using Autodesk.Revit.DB.Events; using System; using System.Collections.Generic; using System.Diagnostics; using System.IO; using System.Linq; using System.Text; using System.Threading.Tasks; using System.Windows.Forms;
 
-namespace APIFinal
+namespace BimApiRevitFamilyParametersGenerator
 {
 	[Autodesk.Revit.Attributes.Transaction(Autodesk.Revit.Attributes.TransactionMode.Manual)]
 
-	public class _0104_test : IExternalCommand
+	public class FamilyParameterGeneratorForm : System.Windows.Forms.Form
 	{
-		private class ObjectType : EqualityComparer<ObjectType>
+		private class DimensionsComparer : EqualityComparer<DimensionsComparer>
 		{
 			int[] _dim = new int[2];
 
@@ -37,7 +37,7 @@
 				get { return H.ToString() + " x " + W.ToString() + "mm"; }
 			}
 
-			public ObjectType(int d1, int d2)
+			public DimensionsComparer(int d1, int d2)
 			{
 				if (d1 > d2)
 				{
@@ -60,10 +60,10 @@
 			}
 		}
 
 		public Result Execute(ExternalCommandData commandData, ref string message, ElementSet elements)
 		{
 
-			void get_number_of_Object(string path, ref int num)
+			void GetNumberOfObjects(string path, ref int num)
 			{
 				StreamReader reader = new StreamReader(path);
 				while (reader.Peek() >= 0)
@@ -75,8 +75,8 @@
 				reader.Close();
 			}
 
 
-			void get_ObjectType(string path, ref int[] L1, ref int[] L2)
+			void GetObjectTypes(string path, ref int[] L1, ref int[] L2)
 			{
 				StreamReader reader = new StreamReader(path);
 				int count = 0;
@@ -93,7 +93,8 @@
 			}
 
 			//for loading the BIM model
-			void load_rfa_element(ref Document document, string path, string name)
+			void LoadRfaElement(ref Document document, string path, string name)
+
 			{
 				Family family = null;
 				using (Transaction tx = new Transaction(document))
@@ -153,12 +154,12 @@
 				int[] length2 = new int[col_num];
 				get_ObjectType(Object_type_path, ref length1, ref length2);
 
-				List<ObjectType> all = new List<ObjectType>();
+				List<DimensionsComparer> allDimensions = new List<DimensionsComparer>();
 				for (int i = 0; i < col_num; ++i)
 					all.Add(new ObjectType(length1[i], length2[i]));
 				all = all.Distinct(new ObjectType(0, 0)).ToList();
 
 
 				load_rfa_element(ref doc, rfa_path, rfa_name);
 
 				//change Object's type
@@ -178,13 +179,13 @@
 				IEnumerable<FamilySymbol> existing
 				= symbols.Cast<FamilySymbol>().Where<FamilySymbol>(x => x.FamilyName.Equals(rfa_name));
 
 				if (0 == existing.Count())
 				{
 					return Result.Cancelled;
 				}
 
-				List<ObjectType> AlreadyExists = new List<ObjectType>();
-				List<ObjectType> ToBeMade = new List<ObjectType>();
+				List<DimensionsComparer> AlreadyExists = new List<DimensionsComparer>();
+				List<DimensionsComparer> ToBeGenerated = new List<DimensionsComparer>();
 
 				for (int i = 0; i < all.Count; ++i)
 				{
@@ -207,7 +208,7 @@
 				//MessageBox.Show("count= " + ToBeMade.Count);
 				using (Transaction tx = new Transaction(doc))
 				{
-					if (tx.Start("Make types") == TransactionStatus.Started)
+					if (tx.Start("Create Types") == TransactionStatus.Started)
 					{
 						FamilySymbol first = existing.First();
 						foreach (ObjectType ct in ToBeMade)
@@ -249,10 +250,10 @@
 						}
 						tx.Commit();
 					}
-					string ObjectMessageBox = "";
+					string _objectTypeMessageBox = "";
 					for (int i = 0; i < col_num; i++)
 					{
-						ObjectMessageBox += "Create " + Object + " " + length1[i] + " X " + length2[i] + " mm\n";
+						_objectTypeMessageBox += "Create " + _objectType + " " + length1[i] + " X " + length2[i] + " mm\n";
 					}
 					MessageBox.Show(ObjectMessageBox);
 				}
@@ -260,7 +261,7 @@
 				return Result.Succeeded;
 			}
 
 			catch(Exception e)
             {
 				Console.WriteLine(e);
             }
@@ -271,8 +272,8 @@
 
 
 /*
-string Object = "Beam";//結構樑or結構柱
-string rfa_name = "混凝土-矩形樑";
-string rfa_path = "C:/ProgramData/Autodesk/RVT 2019/Libraries/China_Trad/結構構架/混凝土/混凝土-矩形樑.rfa";
-string Object_type_path = "C:/Users/jim/Desktop/test.txt";
+string _objectType = "Beam";//結構樑or結構柱
+string rfaName = "混凝土-矩形樑";
+string rfaPath = "C:/ProgramData/Autodesk/RVT 2019/Libraries/China_Trad/結構構架/混凝土/混凝土-矩形樑.rfa";
+string objectTypePath = "C:/Users/jim/Desktop/test.txt";
 */

BIMAPI_HW2/Properties/AssemblyInfo.cs

@@ -5,7 +5,8 @@
 // 組件的一般資訊是由下列的屬性集控制。
 // 變更這些屬性的值即可修改組件的相關
 // 資訊。
-[assembly: AssemblyTitle("BIMAPI_HW2")]
+[assembly: AssemblyTitle("BimApiRevitFamilyParametersGenerator")]
+[assembly: AssemblyProduct("BimApiRevitFamilyParametersGenerator")]
 [assembly: AssemblyDescription("")]
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyCompany("")]

BIMAPI_HW2/Utils.cs

@@ -0,0 +1,25 @@
+// Utils.cs
+
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace BimApiRevitFamilyParametersGenerator
+{
+    public static class Utils
+    {
+        // Utility functions and helper methods
+        // ...
+
+        // Moved utility functions from Form1.Designer.cs
+        // ...
+
+        // Moved utility functions from Form1.cs
+        // ...
+
+        // Moved utility functions from GenerateFamilyParameter.cs
+        // ...
+    }
+}