Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support space between fences and language in fenced code block when applying collapse option #2347

Merged
merged 2 commits into from
May 30, 2024

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented May 30, 2024

fixes #2346

A regression was introduced in 5435c52 which has broken knitr-example, because of space introduced.

Though the collapse problem has not been identified as the example doc as been modified with the breakage
yihui/knitr-examples@931e0a2?diff=split&w=1#diff-2994208929b9d915ac06ca8f58fc66dd26248db5d78be71762508c666e106848

So yihui/knitr-examples#91 fix this, and will be tested with this PR.

as old way will be deprecated
@cderv cderv requested a review from yihui May 30, 2024 13:02
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks!

@yihui yihui merged commit f50b75b into master May 30, 2024
10 checks passed
@yihui yihui deleted the fix/collapse branch May 30, 2024 14:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collapse is not working since 1.46
2 participants