Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean Library & Fantasy Library Translation #64

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

Lugggggia
Copy link
Contributor

@Lugggggia Lugggggia commented Oct 7, 2022

Library, Fantasy Library Translation

Trans Complete Rate

Library - 9%
Fantasy Library - 100%

@notdistorted notdistorted marked this pull request as draft November 10, 2022 08:14
@Lugggggia Lugggggia marked this pull request as ready for review September 10, 2023 00:09
@Lugggggia Lugggggia changed the title [WIP] Korean Library & Fantasy Library Translation Korean Library & Fantasy Library Translation Sep 10, 2023
@cvyl
Copy link

cvyl commented Nov 7, 2023

Nice work, hope it gets approved!

@Mimigris
Copy link
Contributor

Mimigris commented Apr 7, 2024

Sorry for the wait and lack of answer over the time. In addition to the lack of time, the main reason why there was no answer given when you wrote "why aren't this PR accepted until today" is that two days after this, the Fantasy Library got removed from the game alongside most of the assets that you translated.

From what I've seen, it seems that out of the 166 pictures that you translated, only 37 are still present in the files of the game, which are the following:
AA, book txt @sushi2, book txt 893 1-2, book txt yume, book txt 真っ赤なバケツ, gensou32, gensou33, gensou34, gensou35, gensou36, gensou37, gensou38, gensou39, gensou40, gensou44, Kong_色の本_green_picture, Kong_色の本_picture, Kong_色の本_red_picture, Kong_色の本_violet_picture, Kong_色の本_yellow_picture, mudai, spelude-inks1, spelude-inks2, spelude-inks3, かくれんぼ1, かくれんぼ2, かくれんぼ3, かくれんぼ4, にっき 1-1, にっき 1-2, にっき 1-3, にっき 1-4, にっき 1-5, にっき 1-6, にっき 1-7, にっき 1-8, にっき 1-9

Since the handling of files and rules for translating Yume 2kki are intimately tied to the state of the game and that we have to respect the developer's wishes, the assets that got removed would need to be removed from this pull request too. I'm truly sorry for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants