Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default order to match values in CollectUSDLayerContributions #1082

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Update default order to match values in CollectUSDLayerContributions #1082

merged 1 commit into from
Jan 13, 2025

Conversation

MustafaJafar
Copy link
Contributor

@MustafaJafar MustafaJafar commented Jan 13, 2025 •
edited
Loading

Changelog Description

resolve #1081
New default values follow:

ayon-core/client/ayon_core/plugins/publish/extract_usd_layer_contributions.py

Lines 275 to 276 in a141237

"look": 200,
"rig": 300,

Testing notes:

  1. everything should work as before, I've only updated the default values in settings.

@MustafaJafar MustafaJafar requested a review from BigRoy January 13, 2025 21:36
@MustafaJafar MustafaJafar self-assigned this Jan 13, 2025
@MustafaJafar MustafaJafar added the type: bug Something isn't working label Jan 13, 2025
@ynbot ynbot added the size/XS label Jan 13, 2025
BigRoy
BigRoy approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed the correct defaults what it should've been.

@BigRoy BigRoy merged commit b64fb9e into develop Jan 13, 2025
15 checks passed
@BigRoy BigRoy deleted the bugfix/1081-usd-contribution-layers-default-order-mismatch-with-plugin branch January 13, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy approved these changes

Assignees

@MustafaJafar MustafaJafar

Labels
size/XS type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

USD contribution layers default order mismatch with plugin
3 participants
@MustafaJafar @BigRoy @ynbot