Cosmetics + minor optimization for CleanUp plugin
#1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `PublishError` instead of assertion - Optimize the 'check for errors' - Optimize the product type check + log debug message when skipped due to that - Move imports to top
BigRoy
added
community
iLLiCiTiT
reviewed
Jan 15, 2025
| @@ -71,10 +72,12 @@ def process(self, instance): | |||
| self.log.debug("Cleaning renders new...") | |||
| self.clean_renders(instance, skip_cleanup_filepaths) | |||
|
|
|||
| if [ef for ef in self.exclude_families | |||
| if instance.data["productType"] in ef]: | |||
| product_type = instance.data["productType"] | |||
There was a problem hiding this comment.
Oh lord, this plugin...
This condition should probably happen before error checks. And we should change exclude_families to exclude_product_types.
I don't know why there was "str in str" check instead of "str == str"? I guess that is question for @jakubjezek001 who might be able to tell if there are product types that should be skipped too and contain "clip"?
There was a problem hiding this comment.
Oh lord, this plugin...
Thank for sharing my feelings 🙉 🙈 🙊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
PublishErrorinstead of assertionclipyet the product type of the instance wasshotcliporclippyorclip.audiobecause it'd check if the string was IN the product type, it didn't check for exact match (which it does now)Additional info
n/a
Testing notes: