Fixing distribution of otioClip attribute to plates #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubjezek001
added
type: bug
BigRoy
approved these changes
Nov 14, 2024
robin-ynput
approved these changes
Nov 14, 2024
|
Sorry for this I realize this was my mistake. I have reported the fix for Resolve here: ynput/ayon-resolve#41 and will ensure it works properly in Flame as well. |
robin-ynput
requested changes
Nov 14, 2024
iLLiCiTiT
reviewed
Nov 18, 2024
Replaced RuntimeError with PublishError for better error management when retrieving otioClip in both collect_plates and collect_shots. This improves clarity and consistency in the publishing process.
- Imported necessary modules for error handling and utilities. - Updated instance data retrieval to use shot instance data. - Added logic to fetch the correct OTIO clip based on the hero shot's index. - Implemented error raising if the OTIO clip can't be found.
- Added support for "audio" in product type checks. - Simplified creator ID assignments for better readability. - Updated logic to disable shot and audio creators based on conditions.
robin-ynput
approved these changes
Nov 20, 2024
- Added checks for product type in clip creation. - Introduced new methods to define attributes for audio instances. - Updated logic to handle review options more cleanly. - Enhanced shared data management by including `shot_clip_index`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Vertical aligned shot resources are distributed correctly now.
Testing notes:
Resolves #30