feat(fsos): Hiding AAA and SNMP secrets #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either unencrypted (0) or encrypted (7) secrets should be hidden
RayaneB75
changed the title
Using an FS S34000 fully configured switch with AAA and SNMP
Terminal width was insufficient, especially for long SNMP auth/priv hashes
RayaneB75
force-pushed
the
feat/hide-aaa-secrets
branch
from
bdfba15 to
8a0439d
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3354 +/- ##
==========================================
+ Coverage 70.63% 71.06% +0.42%
==========================================
Files 80 82 +2
Lines 3266 3328 +62
==========================================
+ Hits 2307 2365 +58
- Misses 959 963 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either unencrypted (0) or encrypted (7) secrets should be hidden
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
Added multiple cfg.gsub to match every line containing "key ..." to hide unencrypted (
key 0) or encrypted (key 7) secrets.