Skip to content

Commit

Permalink
Put the CMK feature behind a feature flag (#157)
Browse files Browse the repository at this point in the history
  • Loading branch information
cdavid authored Jun 23, 2023
1 parent c2575e6 commit 9e87fed
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 40 deletions.
3 changes: 2 additions & 1 deletion cmd/cluster/encryption/encryption.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"github.com/sirupsen/logrus"
"github.com/spf13/cobra"
"github.com/spf13/viper"
"github.com/yugabyte/ybm-cli/cmd/util"
ybmAuthClient "github.com/yugabyte/ybm-cli/internal/client"
"github.com/yugabyte/ybm-cli/internal/formatter"
ybmclient "github.com/yugabyte/yugabytedb-managed-go-client-internal"
Expand Down Expand Up @@ -161,7 +162,7 @@ var updateCmk = &cobra.Command{
func init() {
EncryptionCmd.AddCommand(listCmk)
EncryptionCmd.AddCommand(updateCmk)
EncryptionCmd.AddCommand(updateCmkState)
util.AddCommandIfFeatureFlag(EncryptionCmd, updateCmkState, util.CLUSTER_CMK_UPDATE)
updateCmk.Flags().String("encryption-spec", "", `[REQUIRED] The customer managed key spec for the cluster.
Please provide key value pairs as follows:
For AWS:
Expand Down
1 change: 1 addition & 0 deletions cmd/util/feature_flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const (
NODE_OP FeatureFlag = "NODE_OPS"
TOOLS FeatureFlag = "TOOLS"
AZURE_CIDR_ALLOWED FeatureFlag = "AZURE_CIDR_ALLOWED"
CLUSTER_CMK_UPDATE FeatureFlag = "CLUSTER_CMK_UPDATE"
)

func (f FeatureFlag) String() string {
Expand Down
1 change: 0 additions & 1 deletion docs/ybm_cluster_encryption.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,4 @@ ybm cluster encryption [flags]
* [ybm cluster](ybm_cluster.md) - Manage cluster operations
* [ybm cluster encryption list](ybm_cluster_encryption_list.md) - List Encryption at Rest (EaR) configurations for a cluster
* [ybm cluster encryption update](ybm_cluster_encryption_update.md) - Update Encryption at Rest (EaR) configurations for a cluster
* [ybm cluster encryption update-state](ybm_cluster_encryption_update-state.md) - Update Encryption at Rest (EaR) state for a cluster

38 changes: 0 additions & 38 deletions docs/ybm_cluster_encryption_update-state.md

This file was deleted.

0 comments on commit 9e87fed

Please sign in to comment.