Adds header_info_size variable to metadata
#77
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alexk101 sorry for the late reaction, I've been quite busy recently. Will take a look later today! |
yunanwg
requested changes
Jan 20, 2025
| @@ -24,6 +24,7 @@ language = "en" | |||
|
|
|||
| # Decide if you want to display profile photo or not | |||
| display_profile_photo = true | |||
| info_font_size = "8pt" | |||
There was a problem hiding this comment.
It would be nice if a comment could be placed above the new item.
| @@ -32,6 +32,7 @@ | |||
| let lastName = metadata.personal.last_name | |||
| let headerQuote = metadata.lang.at(metadata.language).header_quote | |||
| let displayProfilePhoto = metadata.layout.header.display_profile_photo | |||
| let headerInfoFontSize = metadata.layout.header.info_font_size | |||
There was a problem hiding this comment.
For optional value, please use syntax like metadata.layout.at("before_section_skip", default: 1pt) with default value.
There was a problem hiding this comment.
Here you will also need to add eval function, as font size is not string in typst but a special data type.
|
Will try and resolve some of these issues soon |
|
Appreciated! I made a commit yesterday on your PR but don't know why it got lost somewhere. It should not be too complicated, tell me if you encounter any issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #76