This repository has been archived by the owner on Apr 10, 2019. It is now read-only.
#7 test dependency scope #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a lot of issues addressed - #7 Tests moved to the managed sources file tree - #29 Test dependencies moved to the test scope - #17 Triggered execution is now possible - #59 All plugin keys are now prefixed with "swagger" - #66 (partially) Generation split into phases - #1 Compile task seems to be called only once - The generation of controllers now to be triggered manually as suggested by @jroper
| $ exists target/scala-2.11/routes/main/validators/echo.api.yaml.scala | ||
|
|
||
| # we don't check what is created by the play's routes compiler because its outside of our control | ||
|
|
There was a problem hiding this comment.
This test script looks like a great foundation. My approach with scripted tests is to start with something like this, and then as bugs are found and the project evolves, add new ones. As you would be aware, scripted tests can be a little hard to maintain and slow to run, so it's important that every test delivers a lot of value - I think you'll find this test itself will do just that, and as the project evolves you'll find other areas that would benefit from more testing and so warrant the cost of creating new scripted tests for them.
There was a problem hiding this comment.
@jroper Thank you very much for looking into it and for the feedback!
|
Passes travis test and local scripted. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swagger#59 All plugin keys are now prefixed with "swagger"