drv: ft8xx: support multiple instances #83851
Conversation
hubertmis
force-pushed
the
pr/ft8xx_multi_instance
branch
3 times, most recently
from
67f6fa0 to
0e794d0
Compare
|
@kartben, what should I do to receive any feedback on this PR? |
I would recommend trying to raise awareness in the |
There was a problem hiding this comment.
some comments
Also, you should add a note in doc/releases/migration-guide-4.1.rst about the changes you've been making to the API, i.e. indicate that all driver functions now take a device pointer since support for multiple instances has been added AND indicate that there is now also a new user_data parameter added to ft8xx_register_int and to the callback signature ft8xx_int_callback
| { | ||
| (void)dev; | ||
| (void)user_data; | ||
|
|
||
| process_touch = true; | ||
| } | ||
|
|
||
| int main(void) | ||
| { |
There was a problem hiding this comment.
unrelated to your changes but this code should first perform an if device_is_ready(...) check
| */ | ||
| typedef void (*ft8xx_int_callback)(void); | ||
| typedef void (*ft8xx_int_callback)(const struct device *dev, void *user_data); |
There was a problem hiding this comment.
adding support for user data seems to be unrelated to adding support for multiple instances. It would be better to split the changes in different commits
hubertmis
force-pushed
the
pr/ft8xx_multi_instance
branch
from
0e794d0 to
a1467bd
Compare
I've split the pull request into two commits and added notes to the migration guide. |
Improve the FT8xx display driver to support multiple driver instances. The ft8xx_reference_api.h still follows the FT8xx programming guides, limiting the usage of the driver to one instance. Signed-off-by: Hubert Miś <hubert.mis@gmail.com>
The user of the ft8xx driver can register a callback function called on a touch detection interrupt event. This function is extended to include a user-defined pointer. The user-defined pointer helps to share a callback with multiple driver instances. Signed-off-by: Hubert Miś <hubert.mis@gmail.com>
hubertmis
force-pushed
the
pr/ft8xx_multi_instance
branch
from
a1467bd to
ca56e61
Compare
Improve the FT8xx display driver to support multiple driver instances.
The ft8xx_reference_api.h still follows the FT8xx programming guides, limiting the usage of the driver to one instance.