Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: Host: Remove leftover HCI ECC command checks #84573

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

jhedberg
Copy link
Member

The code shouldn't be checking for HCI command support anymore, rather in the case of debug keys we can just start immediately using them.

@jhedberg jhedberg added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Jan 27, 2025
@jhedberg jhedberg requested a review from cvinayak January 27, 2025 06:10
@zephyrbot zephyrbot added area: Bluetooth area: Bluetooth Host Bluetooth Host (excluding BR/EDR) labels Jan 27, 2025
@jhedberg jhedberg changed the title Bluetooth: Host: Remove leftover HCI ECC if-branch Bluetooth: Host: Remove leftover HCI ECC command checks Jan 27, 2025
@cvinayak
Copy link
Contributor

small nit-pick.... @jhedberg just update the commit message to add Fixes commit 09e86f3b69b3112b96d6f89bf388d1ced982aef9 ... pick the rest of the sentence as the compliance check suggests.

This helps me to backtrace in the commit logs.

(FYI, updating the commit messages without any git diff does not need re-approvals).

The code shouldn't be checking for HCI command support anymore, rather in
the case of debug keys we can just start immediately using them.

Fixes commit 09e86f3.

Signed-off-by: Johan Hedberg <johan.hedberg@silabs.com>
@jhedberg
Copy link
Member Author

small nit-pick.... @jhedberg just update the commit message to add Fixes commit 09e86f3b69b3112b96d6f89bf388d1ced982aef9 ... pick the rest of the sentence as the compliance check suggests.

@cvinayak done

@frkv frkv self-requested a review January 27, 2025 09:04
Copy link
Collaborator

@frkv frkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cvinayak cvinayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully with CONFIG_BT_USE_DEBUG_KEYS=y on nRF5340DK in one of my work in progress PR #84496

@kartben kartben merged commit 3ae8a9c into zephyrproject-rtos:main Jan 27, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants