Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mainnet flag in hardhat cctx #166

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix: mainnet flag in hardhat cctx #166

merged 1 commit into from
Aug 7, 2024

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Aug 6, 2024

The task expected boolean, but the argument was passed as a string, so it always defaulted to testnet.

 npx hardhat cctx 0xd8d4f6e45057f355ea657def7026aa9c7496f6ad37550b1cd541c2374b1c3851 --mainnet
✓ CCTXs on ZetaChain found.

✓ 0xe031d59358c10b9275c00a955fffaf9fc70bc0cbe501e7c97c6b96a990f347df: 56 → 7000: OutboundMined (Remote omnichain contract call completed)
✓ 0x9902d0752b34d0a9e5ef17bd5ff27dbcfe6a0bcac9879d3d6c8b202fae3d9b6d: 7000 → 137: OutboundMined (ZRC20 withdrawal event setting to pending outbound directly : Outbound succeeded, mined)

Summary by CodeRabbit

  • New Features

    • Introduced a new boolean flag for the cctxTask function to specify if the task should run on the mainnet, simplifying the command-line interface.
  • Changes

    • Removed the previous optional parameter for network type, enhancing clarity in usage.

@fadeev fadeev requested review from andresaiello and a team as code owners August 6, 2024 06:33
Copy link
Contributor

coderabbitai bot commented Aug 6, 2024

Walkthrough

Walkthrough

The recent changes streamline the configuration of the cctxTask function by replacing the optional string parameter for network type with a boolean flag indicating whether the task should run on the mainnet. This adjustment simplifies the user interface, making it clearer and more intuitive to specify the operational context, while also necessitating updates to existing implementations that depended on the previous parameter setup.

Changes

File Path Change Summary
packages/tasks/src/cctx.ts Modified cctxTask to replace the optional type parameter ("Testnet" or "mainnet") with a boolean flag mainnet, simplifying task invocation.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Task

    User->>Task: Invoke cctxTask with mainnet flag
    Task-->>User: Execute task on mainnet
Loading
sequenceDiagram
    participant User
    participant Task

    User->>Task: Invoke cctxTask with type parameter
    Task-->>User: Execute task based on type (Testnet/Mainnet)
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fadeev
Copy link
Member Author

fadeev commented Aug 6, 2024

@zeta-chain/fullstack please, review.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f0bf8b1 and c766b1b.

Files selected for processing (1)
  • packages/tasks/src/cctx.ts (1 hunks)
Additional comments not posted (2)
packages/tasks/src/cctx.ts (2)

37-38: LGTM! But verify the task usage in the codebase.

The code changes are approved.

However, ensure that all invocations of the cctxTask match the new parameter setup.


Line range hint 29-32:
LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to main match the new signature.

Copy link
Collaborator

@GMaiolo GMaiolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fadeev fadeev merged commit e35a767 into main Aug 7, 2024
5 checks passed
@fadeev fadeev deleted the cctx-mainnet-flag branch August 7, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants