-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mainnet flag in hardhat cctx #166
Conversation
WalkthroughWalkthroughThe recent changes streamline the configuration of the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Task
User->>Task: Invoke cctxTask with mainnet flag
Task-->>User: Execute task on mainnet
sequenceDiagram
participant User
participant Task
User->>Task: Invoke cctxTask with type parameter
Task-->>User: Execute task based on type (Testnet/Mainnet)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
@zeta-chain/fullstack please, review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/tasks/src/cctx.ts (1 hunks)
Additional comments not posted (2)
packages/tasks/src/cctx.ts (2)
37-38
: LGTM! But verify the task usage in the codebase.The code changes are approved.
However, ensure that all invocations of the
cctxTask
match the new parameter setup.
Line range hint
29-32
:
LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
main
match the new signature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
The task expected boolean, but the argument was passed as a string, so it always defaulted to testnet.
Summary by CodeRabbit
New Features
cctxTask
function to specify if the task should run on the mainnet, simplifying the command-line interface.Changes