Mass SMS crud #1005
Open
Mass SMS crud #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanfisk
force-pushed
the
feature/mass-sms-crud
branch
from
9dc6638 to
ebde529
Compare
stefanfisk
force-pushed
the
feature/mass-sms-crud
branch
from
ebde529 to
472a04d
Compare
stefanfisk
commented
Apr 24, 2019
|
|
||
| } = transactionItem.data; | ||
|
|
||
| const receiptUrl = 'http://example.com#not-implemented'; |
There was a problem hiding this comment.
I can't figure out how to implement this. The core endpoint is /orgs/org_id:/sms_distribution_credit_transactions/:transaction_id/receipt, which returns a PDF.
|
Push the credits UI stuff, now this should be complete as far as functionality goes, except for the receipt URLs which I've commented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers CRUD for SMS distributions.
The credits UI still needs to be implemented, so once the 1100 dummy credits are gone sending will fail without there being any user visible explanations as to why.