Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shields): Add physical layout for Lotus58 #2753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ralex2304
Copy link

Added physical layout and studio support for Lotus58.

I've tested changes on my board with this firmware and studio in chrome.

Layout is based on existing zmk layout for Lily58.

@ralex2304 ralex2304 requested a review from a team as a code owner January 6, 2025 00:20
@caksoylar
Copy link
Contributor

I am not sure if this should be a "common" layout under dts/layouts. It is probably better if it is a bespoke layout under the shield folder, like hummingbird.

@caksoylar caksoylar added shields PRs and issues related to shields studio ZMK Studio (runtime keymaps) labels Jan 6, 2025
Added physical layout and studio support for Lotus58.
@ralex2304
Copy link
Author

Fixed and tested.

Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shields PRs and issues related to shields studio ZMK Studio (runtime keymaps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants