Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate (to a configurable limit) very large lock errors #512

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

jamadden
Copy link
Member

Fixes #511

Copy link

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to mention this in the docs somewhere or mention the possibility of adjusting RS_LOCK_ERROR_MAX_LEN in the log message when it is truncated. Otherwise LGTM

@jamadden
Copy link
Member Author

Like all of RelStorage's tunables, it is logged on startup, including its location. That ought to be enough for the interested observer to see what's going on. As a low-level implementation detail subject to change, and one that ought to need adjusting only in very specific circumstances, I'd prefer not to document it more than it already is.

@davisagli
Copy link

@jamadden I see that it's logged at the debug level, which would not show up in my usual deployments. I can imagine that if I ran into a truncated message because of this, and I hadn't seen this PR, I would need to come look at the code to figure out how to avoid it. Anyway, I don't feel strongly about it, since usually I wouldn't need these details.

@jamadden jamadden merged commit 48d7a2d into master Dec 12, 2024
50 of 52 checks passed
@jamadden jamadden deleted the issue511 branch December 12, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain errors can be much too verbose; cap that
2 participants