-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK getResource failOnNoData flag #205
base: main
Are you sure you want to change the base?
Conversation
a2c3109
to
ec5b1e2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 28.25% 28.31% +0.06%
==========================================
Files 146 147 +1
Lines 4987 5047 +60
Branches 869 879 +10
==========================================
+ Hits 1409 1429 +20
- Misses 3578 3618 +40 ☔ View full report in Codecov by Sentry. |
This looks good too - do we need it for use in VSCE somewhere? failOnNoData is added, but is optional, right? Is there any way this could break existing callers? |
ec5b1e2
to
59dbf7c
Compare
Yeah the idea will be we implement this into the VSCE getResource calls so we don't have to handle NODATA CMCI errors. The fact it's optional means we're not breaking current users of the SDK as it's default behavior is not changing; only once you opt in to the new features using these optional flags will the behaviour change. Currently a WIP, looking at an optional flag to change the error you can get out too which will offer more helpful CMCI info on failures (RESP, RESP2 etc) |
59dbf7c
to
0a7c112
Compare
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
b5a79d9
to
c747d05
Compare
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
What It Does
Adds a failOnNodata flag, defaulting to true (which is the current behaviour), to dictate if CMCI sending a NODATA response should throw an error or not.
Review Checklist
I certify that I have:
Additional Comments