Use gateway client attls status in eureka object to determine http vs… #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…send eureka message with compatible http/https information Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
1000TurquoisePogs
force-pushed
the
v3/use-client-attls-status-in-eureka
branch
from
4706d8a to
45a8953
Compare
skurnevich
reviewed
Jan 13, 2025
lib/apiml.js
Outdated
| const clientGatewayAttls = process.env['ZWE_components_gateway_zowe_network_client_tls_attls'] == 'true'; | ||
| const clientAttls = clientGlobalAttls || clientGatewayAttls; | ||
| this.isGatewayClientAttls = false; | ||
| if ((clientGlobalAttls !== false) && (clientLocalAttls !== false) && (!clientAttls)) { |
There was a problem hiding this comment.
I can't see the clientLocalAttls definition is it a typo and should be clientGatewayAttls?
In that case i do not quite understand this condition, i believe it will never pass as clientGlobalAttls and clientGatewayAttls both are defined booleans. if both are true then clientAttls will always be true.
There was a problem hiding this comment.
you're right, this was a mistake of me copying over from the util.js function.
it's not going to have the same logic.
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
skurnevich
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #580 by altering the eureka object's status of https/http true/false dependent upon the status of the gateway's client attls setting.
This is because, client attls alters whether you must send a request as 'http' or 'https' in order to avoid double-tls, or no-tls situations.
In this PR, the app-server reports itself as 'http' if the gateway has client tls enabled, so that when the gateway contacts the app-server, it will HTTPS, as desired.
This logic does not consider the state of the app-server's server ATTLS setting, because whether server ATTLS is enabled or disabled, the app-server should always be HTTPS.