fix(v2): avoid data-loss when creating new members

[zFernand0]

Proposed changes

• Resolves tree(ds): Creating a new member with a conflicting name may cause data-loss #3327

Release Notes

Milestone: next V2 release

Changelog: Prevented data-loss when creating a new member called something that already exists.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

Further comments

[github-actions]

📅 Suggested merge-by date: 1/27/2025

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.58%. Comparing base (176e72c) to head (843a302).

Additional details and impacted files

@@            Coverage Diff             @@
##           v2-lts    #3393      +/-   ##
==========================================
+ Coverage   93.57%   93.58%   +0.01%     
==========================================
  Files         105      105              
  Lines       11186    11194       +8     
  Branches     2468     2488      +20     
==========================================
+ Hits        10467    10476       +9     
+ Misses        719      718       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[traeok]

Thanks for porting this over! I have a suggestion for the changelog, but I tested the functionality and everything LGTM

[sonarqubecloud]

Quality Gate failed

Failed conditions
26.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

[JillieBeanSim]

Thanks for porting this fix over to v2 @zFernand0 for the most part all looks good to me. One thing I noticed was that if the file that is being overwritten is already opened the user has to pull from mainframe to get the latest from the file.
Sidenote! I went to test this same scenario in the v2-lts branch and got the popup asking if I wanted to overwrite so is this PR fixing existing work or introducing the popup? CHANGELOG states the popup is the addition here.

[github-actions]

Reminder: This pull request has a merge-by date coming up within the next 24 hours. Please review this PR as soon as possible.

@t1m0thyj @JillieBeanSim @awharn @traeok