Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #102

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Develop #102

merged 5 commits into from
Oct 7, 2024

Conversation

jmolnar-zscaler
Copy link
Collaborator

ENHANCEMENTS:

  • Module Changes:
    • terraform-zscc-ccvm-aws:
      • add variable additional_management_security_group_ids
    • terraform-zscc-asg-aws:
      • add variable additional_management_security_group_ids
    • terraform-zscc-sg-aws:
      • add resource aws_security_group.outbound_endpoint_sg
      • add variables byo_route53_resolver_outbound_endpoint_group_id and zpa_enabled
    • terraform-zscc-route53-aws:
      • add variable outbound_endpoint_security_group_ids
      • remove default security group usage per AWS best practices

jmolnar-zscaler and others added 5 commits September 20, 2024 22:21
@jmolnar-zscaler @veqryn
Veqryn/additional mgmt security groups (#98)
d315a5f 
* veqryn/additional-mgmt-security-groups

* Allow additional management security groups to work with count

---------

Co-authored-by: Chris Duncan <veqryn@hotmail.com>
@jmolnar-zscaler
chore: description cleanup
1bc75f0
@jmolnar-zscaler
docs(changelog): update
7504c06
@veqryn @jmolnar-zscaler
veqryn: route53 resolver endpoint security group best practices
5eac269
@jmolnar-zscaler
refactor: outbound endpoint security group
1fabb46
nmizhquirizs
nmizhquirizs approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@nmizhquirizs nmizhquirizs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@jmolnar-zscaler jmolnar-zscaler merged commit 8674d43 into release_sep24 Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmizhquirizs nmizhquirizs nmizhquirizs approved these changes

@vkrishnamurthy-zscaler vkrishnamurthy-zscaler Awaiting requested review from vkrishnamurthy-zscaler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmolnar-zscaler @nmizhquirizs @veqryn