Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spidermon. #23

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add spidermon. #23

wants to merge 4 commits into from

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Aug 29, 2024

No description provided.

@wRAR
Copy link
Member Author

wRAR commented Aug 29, 2024

requirements.txt Outdated Show resolved Hide resolved
"Product/name": 1.0,
"Product/metadata": 1.0,
}
SPIDERMON_ITEM_COUNT_INCREASE = 1 # At least 1 item every 5 minutes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels redundant with the recommended CLOSESPIDER_TIMEOUT_NO_ITEM value of 600 in the setup instructions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VMRuiz what do you think?

Comment on lines +127 to +130
The project installs `spidermon <https://spidermon.readthedocs.io/en/latest/>`_
and configures some useful monitors, but it doesn't enable them by default. To
do that you should add ``SPIDERMON_ENABLED = True`` to your project settings
(either ``settings.py`` or Scrapy Cloud settings).
Copy link
Member Author

@wRAR wRAR Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled by default per the today's discussion.

I thought about adding SPIDERMON_ENABLED = False to settings.py but I don't think it's useful,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants