-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-15248: Account Management no change available #11701
Open
jmdembe
wants to merge
49
commits into
main
Choose a base branch
from
jd-LG-15248-hide-change-button
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailable if partner shares all emails
aduth
changed the title
DRAFT: Account Management no change available
DRAFT: LG-15248: Account Management no change available
Jan 6, 2025
jmdembe
commented
Jan 6, 2025
jmdembe
force-pushed
the
jd-LG-15248-hide-change-button
branch
from
January 8, 2025 17:33
85db79e
to
884b507
Compare
jmdembe
changed the title
DRAFT: LG-15248: Account Management no change available
LG-15248: Account Management no change available
Jan 9, 2025
jmdembe
force-pushed
the
jd-LG-15248-hide-change-button
branch
from
January 16, 2025 15:39
0b90166
to
7a3c016
Compare
jmdembe
force-pushed
the
jd-LG-15248-hide-change-button
branch
from
January 16, 2025 20:44
031baec
to
05e9816
Compare
jmdembe
force-pushed
the
jd-LG-15248-hide-change-button
branch
from
January 16, 2025 20:51
05e9816
to
586055d
Compare
jmdembe
force-pushed
the
jd-LG-15248-hide-change-button
branch
from
January 17, 2025 18:02
8ed728f
to
0a8ad18
Compare
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
… check to presenter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15248
🛠 Summary of changes
On the connected accounts screen, the "change" option is not shown when
all_emails
is arequested_attribute
; oremail
does not exist onrequested attribute
📜 Testing Plan
Before testing: Clone, setup, and start the identity-oidc-sinatra app and set
feature_select_email_to_share_enabled
totrue
Default behavior:
identity-oidc-sinatra
app, leave all options checked inrequested_attributes
identity-idp
app, follow all steps to create a new account/account
page. ClickYour connected accounts
on the left side of the pageSimulating missing
email
or presentall_emails
attributeidentity-oidc-sinatra
app, either uncheckemail
or uncheckemail
and checkall_emails
identity-idp
app, follow all steps to create a new account/account
page. ClickYour connected accounts
on the left side of the page👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
When `email` is requested attribute
Screen.Recording.2025-01-08.at.1.46.46.PM.mov
When `all_emails` is a requested attribute
all.emails.no.change.link.mov
When `email` are not a requested attribute
https://github.com/user-attachments/assets/0f3b9cfe-ed76-48ca-8bc9-23e650bec4ea