refactor: move ground wire information into its own procedures #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbirman
commented
Jan 23, 2025
saskiad
reviewed
Jan 24, 2025
| protective_material: ProtectiveMaterial = Field( | ||
| ..., title="Protective material", description="New material being applied" | ||
| procedure_type: Literal["Ground wire implant"] = "Ground wire implant" | ||
| ground_electrode_location: MouseAnatomicalStructure.ONE_OF = Field(..., title="Location of ground electrode") |
There was a problem hiding this comment.
Would it be valuable to have a sublist of structures that we anticipate using for the ground electrode. We currently use BODY_PARTS for the EMG ground wire position, could we make a list called something ~ GROUND_WIRE_PARTS or GROUND_WIRE_LOCATIONS that has all of those plus brain? The full list of anatomical structures is super long and for people using the GUI it will be impossible to navigate
saskiad
requested changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These PR refactors ground wire information out of the protective material replacement procedure and fixes a mistake in the
ProtectiveMaterialReplacement.procedure_typefield.I also added a structure target so that this procedure can be used alongside, e.g. the EMG muscle implant procedure instead of embedding that information in that same procedure. This does imply that procedures might need to reference each other, which suggests we need a name field in
DataModelpotentially...