Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds job to remove staging folder #7

Merged
merged 7 commits into from
Aug 8, 2024
Merged

feat: adds job to remove staging folder #7

merged 7 commits into from
Aug 8, 2024

Conversation

jtyoung84
Copy link
Contributor

Closes #5

  • Adds Job to remove a folder from staging directory
  • Uses dask to prune subdirectories before removing top level folder

@jtyoung84 jtyoung84 requested review from helen-m-lin and dyf August 8, 2024 01:16
@jtyoung84 jtyoung84 marked this pull request as draft August 8, 2024 01:28
@jtyoung84
Copy link
Contributor Author

I'm going to add a dry_run option

@jtyoung84 jtyoung84 marked this pull request as ready for review August 8, 2024 01:34
@jtyoung84 jtyoung84 marked this pull request as draft August 8, 2024 02:09
@jtyoung84
Copy link
Contributor Author

jtyoung84 commented Aug 8, 2024 •
edited
Loading

It looks like I need to use os.walk to ignore following symlinks

@jtyoung84 jtyoung84 marked this pull request as ready for review August 8, 2024 03:02
helen-m-lin
helen-m-lin approved these changes Aug 8, 2024
View reviewed changes
Copy link

@helen-m-lin helen-m-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested locally.

@jtyoung84 jtyoung84 merged commit 92bf275 into main Aug 8, 2024
1 check passed
@jtyoung84 jtyoung84 deleted the feat-5-rm-staging-job branch August 8, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helen-m-lin helen-m-lin helen-m-lin approved these changes

@dyf dyf Awaiting requested review from dyf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Job to remove staging folder using dask
2 participants
@jtyoung84 @helen-m-lin