fix: patches bug with metadata_force_flag

AllenNeuralDynamics · Dec 24, 2024 · a497ea0 · a497ea0
1 parent 1f21220
commit a497ea0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/src/aind_metadata_mapper/models.py b/src/aind_metadata_mapper/models.py
@@ -116,8 +116,8 @@ class JobSettings(BaseSettings, extra="allow"):
         default=None,
         description="Optional path where user defined metadata files might be",
     )
-    metadata_dir_force: bool = Field(
-        default=False,
+    metadata_dir_force: Optional[bool] = Field(
+        default=None,
         description=(
             "Whether to override the user defined files in metadata_dir with "
             "those pulled from metadata service"

diff --git a/tests/test_gather_metadata.py b/tests/test_gather_metadata.py
@@ -169,7 +169,6 @@ def test_get_subject_from_dir(self, mock_get: MagicMock):
                 subject_id="632269",
             ),
             metadata_dir=metadata_dir,
-            metadata_dir_force=True,
         )
         metadata_job = GatherMetadataJob(settings=job_settings)
         contents = metadata_job.get_subject()
@@ -238,7 +237,6 @@ def test_get_procedures_from_dir(self, mock_get: MagicMock):
                 subject_id="632269",
             ),
             metadata_dir=metadata_dir,
-            metadata_dir_force=True,
         )
         metadata_job = GatherMetadataJob(settings=job_settings)
         contents = metadata_job.get_procedures()
@@ -325,7 +323,6 @@ def test_get_raw_data_description_from_dir(self, mock_get: MagicMock):
                 modality=[Modality.ECEPHYS, Modality.BEHAVIOR_VIDEOS],
             ),
             metadata_dir=metadata_dir,
-            metadata_dir_force=True,
         )
         metadata_job = GatherMetadataJob(settings=job_settings)
         contents = metadata_job.get_raw_data_description()
@@ -477,7 +474,6 @@ def test_get_processing_metadata_from_dir(self):
                 )
             ),
             metadata_dir=metadata_dir,
-            metadata_dir_force=True,
         )
         metadata_job = GatherMetadataJob(settings=job_settings)
         contents = metadata_job.get_processing_metadata()
@@ -1062,7 +1058,6 @@ def test_project_name_is_set(self):
                 metadata_service_path="funding",
             ),
             directory_to_write_to="/some/dir/data_dir",
-            metadata_dir_force=False,
         )
 
         job = GatherMetadataJob(settings=settings)