Enh/neuropixels rig #17
Conversation
| class NeuropixelsRigException(Exception): | ||
| """General error for MVR.""" | ||
|
|
||
|
|
There was a problem hiding this comment.
Go ahead and make pydantic models for these.
There was a problem hiding this comment.
e.g.
class MvrCamera(BaseModel):
assembly_name: str
serial_number: str
height: int
width: int
frame_rate: float|
|
||
| return rig.Rig.parse_obj({ | ||
| **partial, | ||
| "modification_date": datetime.date.today(), |
There was a problem hiding this comment.
add modification_date to the arg list. you can mention in the defaults that None means today().
| """ | ||
| super().__init__(input_source, output_directory) | ||
|
|
||
| def _load_resource(self, path: pathlib.Path) -> str: |
There was a problem hiding this comment.
I don't think you need this function - read_text should say something to this effect if the file does not exist.
|
|
||
| def __init__( | ||
| self, | ||
| input_source: pathlib.Path, |
There was a problem hiding this comment.
source is always a directory, right? if so you can call this input_directory
| "aind-metadata-service[client]", | ||
| "scanimage-tiff-reader==1.4.1.4" | ||
| "scanimage-tiff-reader==1.4.1.4", | ||
| "pyyaml==6.0.1" |
There was a problem hiding this comment.
Maybe? Pyyaml released breaking changes between 5.0 and 6.0 so I figured pinning was safest in case of pyyaml 7.0.
|
@mochic let's please also make the name of the module more specific. maybe: |
Adds neuropixels rig mapping for mpe sync config sync.yml and mvr config mvr.ini. An additional non-mpe config mvr.mapping.json is used to map mvr camera names to camera assembly names in the rig. Aside from sync and camera assembly information, the rest of the rig information is static and rehydrated from rig.partial.json.