-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ophys stim epochs and fov #193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f metadata schema
…ntate depdendency
…euralDynamics/aind-metadata-mapper into ophys-stim-epochs-and-fov
default=None, title="Optional output path" | ||
) | ||
|
||
@field_validator("input_source", "behavior_source", "output_directory") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this field_validator? It's empty
mekhlakapoor
approved these changes
Nov 15, 2024
mekhlakapoor
dismissed
Ahad-Allen’s stale review
November 15, 2024 20:51
Dismissing requested change because linters have been fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a huge amount of changes to create the session.json for the mesoscope platforms.
@mekhlakapoor and @rcpeene : I did not unit test the OpenEphysCamstim object but I am guessing it can follow what I did for the parent Camstim class. It also needs to be tested to make sure that the opto files generate properly.
@Ahad-Allen - Will you please verify the camstim tests are producing values you would expect from the methods that build both the stim tables and epochs