Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ophys stim epochs and fov #193

Merged
merged 209 commits into from
Nov 15, 2024
Merged

Ophys stim epochs and fov #193

merged 209 commits into from
Nov 15, 2024

Conversation

arielleleon
Copy link
Contributor

This contains a huge amount of changes to create the session.json for the mesoscope platforms.

  • Pull metadata for FieldOfView generation from tiff header and hdf5 files
  • Index FieldOfView objects correctly
  • Correctly add coupled_fov_index
  • Parse platform.json for new power fields
  • Create stim_epochs
  • Add session_types
  • Create data_description.json to save project codes in the summary attribute
  • Remodel the camstim module so the parent class generates visual stimuli
  • Add unit tests for camstim module
  • Add unit tests for mesoscope
  • Add resources for testing mesoscope session.json

@mekhlakapoor and @rcpeene : I did not unit test the OpenEphysCamstim object but I am guessing it can follow what I did for the parent Camstim class. It also needs to be tested to make sure that the opto files generate properly.

@Ahad-Allen - Will you please verify the camstim tests are producing values you would expect from the methods that build both the stim tables and epochs

rcpeene and others added 30 commits May 3, 2024 14:58
@mekhlakapoor mekhlakapoor marked this pull request as draft November 14, 2024 19:05
default=None, title="Optional output path"
)

@field_validator("input_source", "behavior_source", "output_directory")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this field_validator? It's empty

@mekhlakapoor mekhlakapoor marked this pull request as ready for review November 15, 2024 19:30
@mekhlakapoor mekhlakapoor dismissed Ahad-Allen’s stale review November 15, 2024 20:51

Dismissing requested change because linters have been fixed

@arielleleon arielleleon merged commit 770496c into dev Nov 15, 2024
3 checks passed
@arielleleon arielleleon deleted the ophys-stim-epochs-and-fov branch November 15, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants