Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: clarifies behavior of user metadata dir #217

Merged
merged 1 commit into from
Dec 18, 2024
Merged

feat: clarifies behavior of user metadata dir #217

merged 1 commit into from
Dec 18, 2024

Conversation

jtyoung84
Copy link
Contributor

Closes #213

  • Removes check of metadata_dir_force flag
  • Behavior is, if user supplies pre-compiled metadata file, then it assume that is the source of truth. If they did not supply one, then try to build one automatically.

@jtyoung84 jtyoung84 merged commit 036572e into dev Dec 18, 2024
3 checks passed
@jtyoung84 jtyoung84 deleted the feat-213-metadata-dir branch December 18, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mekhlakapoor mekhlakapoor mekhlakapoor approved these changes

@helen-m-lin helen-m-lin helen-m-lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When a user supplies their own metadata file, always consider it the source of truth.
3 participants
@jtyoung84 @helen-m-lin @mekhlakapoor