Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat 33 schema version #40

Merged
merged 8 commits into from
Apr 8, 2024
Merged

Feat 33 schema version #40

merged 8 commits into from
Apr 8, 2024

Conversation

jtyoung84
Copy link
Contributor

Closes #33

arielleleon
arielleleon reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@arielleleon arielleleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made one comment about a duplicate object

src/aind_metadata_mapper/bergamo/session.py
photostim_groups[0]["rois"][1][
"scanfields"
]["repetitions"]
PhotoStimulationGroup(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtyoung84 This looks like a duplicate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they're close, but there is a slight difference with the group index

@jtyoung84 jtyoung84 requested a review from arielleleon April 8, 2024 17:47
arielleleon
arielleleon approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@arielleleon arielleleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving as is until Kayvon and Marton finish the final draft with Saskia

@jtyoung84 jtyoung84 merged commit 002b3f4 into main Apr 8, 2024
2 checks passed
@jtyoung84 jtyoung84 deleted the feat-33-schema-version branch April 8, 2024 17:51
@jtyoung84 jtyoung84 mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielleleon arielleleon arielleleon approved these changes

@micahwoodard micahwoodard Awaiting requested review from micahwoodard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtyoung84 @arielleleon