Enh/neuropixels improvements #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekhlakapoor
reviewed
May 9, 2024
| ) | ||
|
|
||
|
|
||
| class TestOpenEphysRigEtlModificationDateUpdate(unittest.TestCase): |
There was a problem hiding this comment.
rather than making a new module and class, you can put these unit tests in the test_open_ephys_rig module
There was a problem hiding this comment.
Addressed here:
d3a041f
mekhlakapoor
requested changes
May 9, 2024
mekhlakapoor
approved these changes
May 9, 2024
|
I made the changes that @mekhlakapoor and @dyf requested. |
dyf
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the open ephys etl to not update modification date and rig_id if the model doesnt change.