Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug where couldn't put contracts_folder in dependency config_override config #1819

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Jan 5, 2024

What I did

dependencies let you specify contracts_folder as a key but also offer a config_override.
however, when putting contracts_folder in config_override (which should be valid because contracts_folder is also a project's top-level config item), it fails with got multiple args for keyword 'contracts_folder', so this fixes that.

How I did it

check if contracts_folder is in config override. if no, then put the one you were gonna put else, leave it be.

How to verify it

dependencies:
  - name: solmate
    github: transmissions11/solmate
    ref: "v6"
    #contracts_folder: src
    config_override:
      contracts_folder: src
      compile:
        exclude: 
          - ./test/utils/*

run ape pm compile

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey requested a review from fubuloubu January 5, 2024 17:22
@antazoey antazoey merged commit d2f31ef into ApeWorX:main Jan 5, 2024
15 checks passed
@antazoey antazoey deleted the fix/double-contracts-folder branch January 5, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants