fix: bug where couldn't put contracts_folder in dependency config_override config

src/ape/api/projects.py

@@ -477,9 +477,11 @@ def compile(self, use_cache: bool = True) -> PackageManifest:
         with tempfile.TemporaryDirectory() as temp_dir:
             path = Path(temp_dir)
             contracts_folder = path / config_data.get("contracts_folder", "contracts")
-            with self.config_manager.using_project(
-                path, contracts_folder=contracts_folder, **config_data
-            ) as project:
+
+            if "contracts_folder" not in config_data:
+                config_data["contracts_folder"] = contracts_folder
+
+            with self.config_manager.using_project(path, **config_data) as project:
                 manifest.unpack_sources(contracts_folder)
                 compiled_manifest = project.local_project.create_manifest()
 

tests/functional/test_dependencies.py

@@ -123,6 +123,19 @@ def test_npm_dependency(mock_home_directory):
             shutil.rmtree(package_folder)
 
 
+def test_decode_with_config_override(dependency_manager, project):
+    settings = {".json": {"evm_version": "paris"}}
+    path = "__test_path__"
+    base_path = project.path / path
+    contracts_path = base_path / "contracts"
+    contracts_path.mkdir(parents=True)
+    (contracts_path / "contract.json").write_text('{"abi": []}')
+
+    data = {"name": "FooBar", "local": path, "config_override": settings}
+    dependency = dependency_manager.decode_dependency(data)
+    assert dependency.config_override == settings
+
+
 def test_compile(project_with_downloaded_dependencies):
     name = "OpenZeppelin"
     oz_442 = project_with_downloaded_dependencies.dependencies[name]["4.4.2"]
@@ -131,17 +144,19 @@ def test_compile(project_with_downloaded_dependencies):
     assert len(actual.contract_types) > 0
 
 
-def test_compile_with_extra_settings(dependency_manager, project):
-    settings = {".json": {"evm_version": "paris"}}
+def test_compile_with_config_override(dependency_manager, project):
+    # NOTE: It is important that `contracts_folder` is present in settings
+    #  for this test to test against a previous bug where we got multiple values.
+    override = {"contracts_folder": "src"}
     path = "__test_path__"
-    base_path = project.path / path
-    contracts_path = base_path / "contracts"
-    contracts_path.mkdir(parents=True)
+    contracts_path = project.path / path / "contracts"
+    contracts_path.mkdir(exist_ok=True, parents=True)
     (contracts_path / "contract.json").write_text('{"abi": []}')
-
-    data = {"name": "FooBar", "local": path, "config_override": settings}
+    data = {"name": "FooBar", "local": path, "config_override": override}
     dependency = dependency_manager.decode_dependency(data)
-    assert dependency.config_override == settings
+
+    actual = dependency.compile()
+    assert len(actual.contract_types) > 0
 
 
 def test_github_dependency_ref_or_version_is_required():