Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(haystack): ensure compatibility with haystack 2.9 #1205

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

lambda-science
Copy link
Contributor

The wrapper doesn't work with haystack 2.9.0 because .content has been deleted, we should use .text now

@lambda-science lambda-science requested a review from a team as a code owner January 16, 2025 15:30
Copy link
Contributor

github-actions bot commented Jan 16, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 16, 2025
@lambda-science
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jan 16, 2025
@axiomofjoy axiomofjoy self-assigned this Jan 17, 2025
@axiomofjoy
Copy link
Contributor

Thanks so much for reporting @lambda-science!

@axiomofjoy axiomofjoy changed the title .content is deleted in haystack 2.9.0, should use .text now fix(haystack): ensure compatibility with haystack 2.9 Jan 17, 2025
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 17, 2025
@axiomofjoy
Copy link
Contributor

Dropping support for Python 3.9. Haystack still continues to support it, but it has reached EOL and is complicating our testing strategy with vcrpy.

@axiomofjoy axiomofjoy merged commit 6ee2ebf into Arize-ai:main Jan 17, 2025
3 checks passed
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. size:M This PR changes 30-99 lines, ignoring generated files. labels Jan 17, 2025
@lambda-science
Copy link
Contributor Author

Dropping support for Python 3.9. Haystack still continues to support it, but it has reached EOL and is complicating our testing strategy with vcrpy.

Do you know how / when this fix will be included in arizephoenix/phoenix:latest ? :)

@axiomofjoy
Copy link
Contributor

Hey @lambda-science, this has been released in openinference-instrumentation-haystack 0.1.14 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[bug][haystack] .content is deleted in haystack 2.9.0, should use .text now
2 participants