Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(haystack): ensure compatibility with haystack 2.9 #1205

Merged
merged 3 commits into from
Jan 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ dynamic = ["version"]
description = "OpenInference Haystack Instrumentation"
readme = "README.md"
license = "Apache-2.0"
requires-python = ">=3.8, <3.13"
requires-python = ">=3.9, <3.13"
authors = [
{ name = "OpenInference Authors", email = "oss@arize.com" },
]
Expand Down Expand Up @@ -37,14 +37,14 @@ dependencies = [

[project.optional-dependencies]
instruments = [
"haystack-ai >= 2.0.0",
"haystack-ai >= 2.9.0",
]
test = [
"haystack-ai==2.3.1",
"haystack-ai==2.9.0",
"cohere-haystack",
"opentelemetry-sdk",
"vcrpy>=7.0.0",
"pytest-recording",
"respx",
]

[project.urls]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

logger = logging.getLogger(__name__)

_instruments = ("haystack-ai >= 2.0.0",)
_instruments = ("haystack-ai >= 2.9.0",)


class HaystackInstrumentor(BaseInstrumentor): # type: ignore[misc]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import json
from abc import ABC
from enum import Enum, auto
from inspect import BoundArguments, Parameter, signature
Expand Down Expand Up @@ -380,7 +379,7 @@ def _get_llm_input_message_attributes(arguments: Mapping[str, Any]) -> Iterator[
map(lambda x: isinstance(x, ChatMessage), messages)
):
for message_index, message in enumerate(messages):
if (content := message.content) is not None:
if (content := message.text) is not None:
yield f"{LLM_INPUT_MESSAGES}.{message_index}.{MESSAGE_CONTENT}", content
if (role := message.role) is not None:
yield f"{LLM_INPUT_MESSAGES}.{message_index}.{MESSAGE_ROLE}", role
Expand Down Expand Up @@ -408,25 +407,20 @@ def _get_llm_output_message_attributes(response: Mapping[str, Any]) -> Iterator[
):
continue
if finish_reason == "tool_calls":
try:
tool_calls = json.loads(reply.content)
except json.JSONDecodeError:
continue
tool_calls = reply.tool_calls
for tool_call_index, tool_call in enumerate(tool_calls):
if (function_call := tool_call.get("function")) is None:
continue
if (tool_call_arguments_json := function_call.get("arguments")) is not None:
if (tool_call_arguments := tool_call.arguments) is not None:
yield (
f"{LLM_OUTPUT_MESSAGES}.{reply_index}.{MESSAGE_TOOL_CALLS}.{tool_call_index}.{TOOL_CALL_FUNCTION_ARGUMENTS_JSON}",
tool_call_arguments_json,
safe_json_dumps(tool_call_arguments),
)
if (tool_name := function_call.get("name")) is not None:
if (tool_name := tool_call.tool_name) is not None:
yield (
f"{LLM_OUTPUT_MESSAGES}.{reply_index}.{MESSAGE_TOOL_CALLS}.{tool_call_index}.{TOOL_CALL_FUNCTION_NAME}",
tool_name,
)
else:
yield f"{LLM_OUTPUT_MESSAGES}.{reply_index}.{MESSAGE_CONTENT}", reply.content
yield f"{LLM_OUTPUT_MESSAGES}.{reply_index}.{MESSAGE_CONTENT}", reply.text
yield f"{LLM_OUTPUT_MESSAGES}.{reply_index}.{MESSAGE_ROLE}", reply.role.value
elif isinstance(reply, str):
yield f"{LLM_OUTPUT_MESSAGES}.0.{MESSAGE_CONTENT}", reply
Expand Down
Loading
Loading