[Unity Catalog] - Update Readme for Unity Catalog (#978) #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesqlpro
requested review from
bsherwin,
elenaterenzi,
ydaponte and
LiliamLeme
3 tasks
ydaponte
requested changes
Jan 9, 2025
| - *Permissions needed*: If a regional metastore does not exist then an account admin must create one. [Metastore Creation](https://learn.microsoft.com/en-us/azure/databricks/data-governance/unity-catalog/create-metastore) | ||
| - *Permissions needed*: Once the catalog is created, the following permissions must be granted to *All account users* in order to run the notebooks *02_standardize.py* and *03_tranfsorm.py*. | ||
| - USE CATALOG, USE SCHEMA, CREATE TABLE, MODIFY, SELECT | ||
| - Alternatively these permissions can be given to the MSI generated for the Databricks Linked Service in ADF. This is the recommended approach and a better security practice. However since a separate catalog is created for this demo environment, granting privelages to *All account users* is a potential work around as many of the APIs for managing Unity Catalog are still being developed as of the writing of these instructions. |
There was a problem hiding this comment.
Related with the previous point, you mention now that a separate catalog is created for this demo environment - where is this being created? In the setup notebook you mention "Use the Sensor Catalog Created in the Prerequisites " - so in the prerequisites you are generally asking to follow the instructions to create the "Unity Catalog", but I was expecting that the metastore regional piece was manual and the catalog could be added to the automation. On a second note - maybe the ReadMe needs to go together with the code changes when they are ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Update to Readme to add Unity Catalog instructions
Purpose
Unity Catalog is a new addition to this repo. By default it is added to all new Databricks workspaces. This documentation addition allows users of the repo to create a metastore and catalog for this sample.
Author pre-publish checklist
Validation steps
Issues Closed or Referenced
#978
Following tasks also rely on it
#982
#984
#983
#765