Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unity Catalog] - Update Readme for Unity Catalog (#978) #996
[Unity Catalog] - Update Readme for Unity Catalog (#978) #996
Changes from 1 commit
9d51d93
94733dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related with the previous point, you mention now that a separate catalog is created for this demo environment - where is this being created? In the setup notebook you mention "Use the Sensor Catalog Created in the Prerequisites " - so in the prerequisites you are generally asking to follow the instructions to create the "Unity Catalog", but I was expecting that the metastore regional piece was manual and the catalog could be added to the automation. On a second note - maybe the ReadMe needs to go together with the code changes when they are ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all of these [Unity Catalog] PRs related? Can one get published before the others or do they need to be all three or nothing?