Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK Suppressions labels] Add new action to update suppressions labels #31878

Merged
merged 194 commits into from
Jan 8, 2025
Merged

[SDK Suppressions labels] Add new action to update suppressions labels #31878

merged 194 commits into from
Jan 8, 2025

Conversation

JackTn
Copy link
Member

@JackTn JackTn commented Dec 13, 2024

add new action to update sdk-suppression label

Overview :
Add sdk-suppressions file to process sdk breaking change

Changes:

  • [.github/workflows/SDK-Suppressions-Label.yaml] main action added trigger by pull request
  • [.github/workflows/update-labels.yaml] add trigger to update label
  • [eng/tools/package.json] dependence config for sdk-suppressions
  • [eng/tools/sdk-suppressions] main code to process sdk-suppressions label base diff by pr sdk-suppression.yaml file

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 13, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 13, 2024 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@JackTn JackTn force-pushed the jacktn/suppression-action branch from 1401313 to ec018c2 Compare December 17, 2024 11:47
@JackTn JackTn marked this pull request as ready for review December 17, 2024 13:05
mikeharder
mikeharder requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address review feedback

@JackTn JackTn force-pushed the jacktn/suppression-action branch from 6cb5e49 to 5b11a33 Compare December 19, 2024 14:28
@JackTn JackTn requested review from mikeharder and raych1 December 19, 2024 14:30
@raych1
Copy link
Member

raych1 commented Dec 19, 2024

@mikeharder could you review again?

@JackTn JackTn force-pushed the jacktn/suppression-action branch from 62f6013 to be7b892 Compare December 20, 2024 05:32
@JackTn JackTn requested a review from raych1 December 20, 2024 06:45
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Jan 6, 2025
mikeharder
mikeharder requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change dependency, and verify if label artifacts should be generate for both true and false.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the no-recent-activity There has been no recent activity on this issue. label Jan 7, 2025
@JackTn JackTn requested a review from mikeharder January 7, 2025 06:13
@raych1 raych1 mentioned this pull request Jan 7, 2025
Closed
@raych1 raych1 merged commit ef19a22 into Azure:main Jan 8, 2025
43 of 46 checks passed
santiagxf pushed a commit to santiagxf/azure-rest-api-specs that referenced this pull request Jan 15, 2025
@JackTn @mikeharder
@raych1 @santiagxf
[SDK Suppressions labels] Add new action to update suppressions labels (
6cb94a6 
Azure#31878)

* initial version

* use variables to be used in next steps

* removed unused code and test branch

* added function description

* updated dependencies

* removed test branch

* add comment to to explain this behavior

* Add trailing newline

---------

Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Ray Chen <raychen@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeharder mikeharder mikeharder approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@raych1 raych1 Awaiting requested review from raych1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackTn @raych1 @mikeharder