Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6878] Fix API filter for versioned guids/preprints #10905

Conversation

cslzchen
Copy link
Collaborator

@cslzchen cslzchen commented Jan 9, 2025

Purpose

Fix API filter for versioned guids/prepirnts

Changes

  • Revert incorrect fix that broke Preprint filter by _id
  • Implement filter mixin for preprint action and review action to filter by _id

Tests Fixed

FAILED api_tests/preprints/views/test_preprint_actions.py::TestPreprintActionFilters::test_filter_actions[moderator] - AssertionError
FAILED api_tests/preprints/views/test_preprint_actions.py::TestPreprintActionFilters::test_filter_actions[node_admin] - AssertionError
FAILED api_tests/users/views/test_user_actions.py::TestReviewActionFilters::test_filter_actions - AssertionError

QA Notes

N/A

Documentation

N/A

Side Effects

N/A

Ticket

https://openscience.atlassian.net/browse/ENG-6878

@cslzchen cslzchen changed the title Draft PR [TBD] Fix API filter for versioned guids/preprints Jan 9, 2025
@cslzchen cslzchen marked this pull request as ready for review January 10, 2025 03:45
@cslzchen cslzchen changed the title [TBD] Fix API filter for versioned guids/preprints [ENG-6878] Fix API filter for versioned guids/preprints Jan 10, 2025
@cslzchen cslzchen requested a review from brianjgeiger January 10, 2025 15:35
Copy link
Collaborator

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks fine, and doesn't look like it'll break root filtering for nodes. It has been a while since I've played around in this part of the codebase though.

@cslzchen cslzchen merged commit a5b4e05 into CenterForOpenScience:feature/preprints-doi-versioning Jan 10, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants