Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6815][ENG-6881] Fix missing original admin contributor + Sync BE/FE permission logic for edit #10906

Merged
merged 3 commits into from
Jan 10, 2025
Merged

[ENG-6815][ENG-6881] Fix missing original admin contributor + Sync BE/FE permission logic for edit #10906

merged 3 commits into from
Jan 10, 2025

Conversation

cslzchen
Copy link
Collaborator

@cslzchen cslzchen commented Jan 9, 2025 •
edited
Loading

Purpose

Fix missing original admin contributor and sync BE/FE permission logic for edit

Changes

  • Exclude the new version's creator instead of the latest version's creator when adding contributor to a new version
  • Update BE permission check and sync with FE for whether to allow edit

QA Notes

N/A

Documentation

N/A

Side Effects

N/A

Ticket

@cslzchen cslzchen changed the title [TBD] Fix edit permission and adding contributor [ENG-6815][ENG-6881] Fix missing original admin contributor + Sync BE/FE permission logic for edit Jan 9, 2025
@cslzchen cslzchen marked this pull request as ready for review January 10, 2025 03:45
@cslzchen cslzchen merged commit bc6ceae into CenterForOpenScience:feature/preprints-doi-versioning Jan 10, 2025
5 of 6 checks passed
@cslzchen cslzchen mentioned this pull request Jan 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cslzchen