-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MoM] Add some more nether attunement consequences #79159
Merged
Maleclypse
merged 14 commits into
CleverRaven:master
from
Standing-Storm:more-nether-attunement-consequences
Jan 24, 2025
Merged
[MoM] Add some more nether attunement consequences #79159
Maleclypse
merged 14 commits into
CleverRaven:master
from
Standing-Storm:more-nether-attunement-consequences
Jan 24, 2025
+207
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
EOC: Effects On Condition
Anything concerning Effects On Condition
Mods: Mind Over Matter
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Jan 14, 2025
github-actions
bot
added
Mechanics: Enchantments / Spells
Enchantments and spells
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Jan 14, 2025
fungamer2-2
reviewed
Jan 14, 2025
data/mods/MindOverMatter/effectoncondition/eoc_nether_attunement_events.json
Outdated
Show resolved
Hide resolved
data/mods/MindOverMatter/effectoncondition/eoc_nether_attunement_events.json
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jan 16, 2025
…com/Standing-Storm/Cataclysm-DDA into more-nether-attunement-consequences
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
EOC: Effects On Condition
Anything concerning Effects On Condition
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: Mind Over Matter
Mods
Issues related to mods or modding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[MoM] Add some more nether attunement consequences"
Purpose of change
Nether Attunement is Fun™
Also, a couple backlashes should reroll if you're totally ineligible for them (the ones that require Observed or Nether Conduit if you're not Observed and don't have Nether Conduit).All backlashes now do thisDescribe the solution
In addition:
Turn the health-affecting backlash into directly modifying u_healthy(), from an effect that applies a random base_mod.
Add checks for the Observed/Conduit-required effects and reroll your backlash if you're ineligible for those.
Describe alternatives you've considered
Testing
Checked each consequence and made sure they did what they're supposed to.
Additional context
The lightning can happen with any path because it's spoOoky eldritch lightning