Electronic storage overhaul migration fix #79311
Open
+26
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "electronic storage overhaul migration fix"
Purpose of change
Closes #79299
When I wrote the migration code for #79097, evidently I removed some code that was still being used.
Describe the solution
Put the MOD reading code back for migration, ignore CONTAINER for migration.
Describe alternatives you've considered
Testing
Tested with the save from #79299, mods were back on guns, no additional errors.
Additional context
I really should have asked before I changed this code in the first place. It looks like it was to migrate contents for when pockets were introduced, but I don't know how much of it still really needs to be there.
I guess I'm asking for a second opinion if anybody knows better.