Updated checklist tick icon colour contrast #3698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethwilliamsdesign
temporarily deployed
to
review_aks
GitHub Actions
Inactive
|
Revised icons look much better @garethwilliamsdesign Couple of comments: 1) Alignment The icons look good on
2) Windows High Contrast The icons don't work as well in Windows High Contrast - however, it may be easier to address this as a wider icon issue in a separate PR?
|
|
I'm happy to address the icon issue in high contrast mode as a separate PR. |
garethwilliamsdesign
temporarily deployed
to
review_aks
GitHub Actions
Inactive
|
AKS Review app deployed to https://get-into-teaching-app-review-3698.test.teacherservices.cloud |
|
Kudos, SonarCloud Quality Gate passed! |
gemmadallmandfe
approved these changes
Nov 14, 2023
gemmadallmandfe
temporarily deployed
to
review_aks
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Trello 5249
Trello 5250
Context
The colour contrast difference between the non-text element’s white colour (#FFFFFF) and the yellow background (#FBBA20) is 1.72:1. This does not meet the AA standard of 3:1.
Also, the colour contrast difference between the non-text element’s yellow colour (#FBBA20) and the grey background (#F0F0F0) is 1.51:1. This does not meet the AA standard of 3:1.
Changes proposed in this pull request
Replace the current tick icon - which, as a rounded Font Awesome icon, does not match the styling of other ticks on the website - with the same tick icon as is used in the GIT logo. Also, remove the yellow background as this only serves to complicate the colour contrast issue.
Guidance to review
Check that the rounded tick in a yellow box has been replaced by a sharper tick in a box, to match the icon in the GIT logo.